Implement missing Feature::set_field_*_list funcs #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttencate
force-pushed
the
feature/set_list_field_types
branch
from
d420110 to
4743529
Compare
|
@ttencate this PR looks great. Could you add the changelog entry? I'll merge it when done. |
Also reuse field_idx_from_name instead of duplicating it all over the place.
ttencate
force-pushed
the
feature/set_list_field_types
branch
from
4743529 to
0cc4c58
Compare
|
@rmanoka Done. The clippy fails seem unrelated to this PR. |
|
Suprising the ci fails as we use bors. This may likely fail but let's see. bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 3, 2022
278: Implement missing Feature::set_field_*_list funcs r=rmanoka a=ttencate Also reuse field_idx_from_name instead of duplicating it all over the place. - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- If you think it's worth a changelog entry, I'll be happy to add one right before merge, to save myself some merge conflicts. Co-authored-by: Thomas ten Cate <ttencate@gmail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
On vacation, will do when I get home.
…On Thu, Jun 23, 2022, 09:34 rmanoka ***@***.***> wrote:
@ttencate <https://github.com/ttencate> this PR looks great. Could you
add the changelog entry? I'll merge it when done.
—
Reply to this email directly, view it on GitHub
<#278 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWGMRT2BLDTBEGTOELCKDVQQHPDANCNFSM5XVCK56Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reuse field_idx_from_name instead of duplicating it all over the
place.
CHANGES.mdif knowledge of this change could be valuable to users.If you think it's worth a changelog entry, I'll be happy to add one right before merge, to save myself some merge conflicts.