add a driver manager wrapper #324
Conversation
|
@ChristianBeilschmidt It's interesting that we both were doing work on this at the same time (but I think for different reasons). Here's what I was doing: https://github.com/georust/gdal/pull/323/files Why do you think |
src/driver.rs
Outdated
| /// | ||
| /// ```rust, no_run | ||
| /// use gdal::Driver; | ||
| /// println!("{} drivers are registered", Driver::count()); |
There was a problem hiding this comment.
If Driver is to be deprecated, should these examples be updated?
There was a problem hiding this comment.
As far as I see GDAL's C++-API, it is structured as I did above. It differentiates between DriverManager and Driver. So it makes sense from my point of view to put these methods (previously in Driver) there. |
ChristianBeilschmidt
force-pushed
the
dataset-removal
branch
from
b16c050 to
49fdfd4
Compare
|
@ChristianBeilschmidt Thanks for explaining the correspondence with the C++ implementation. I wasn't aware of that. |
|
it looks good to me |
| pub fn get_driver(index: usize) -> Result<Driver> { | ||
| _register_drivers(); | ||
| let c_driver = unsafe { gdal_sys::GDALGetDriver(index.try_into().unwrap()) }; | ||
| if c_driver.is_null() { |
There was a problem hiding this comment.
I don't think GDALGetDriver sets the last error: https://github.com/OSGeo/gdal/blob/master/gcore/gdal_priv.h#L1734. _last_null_pointer_err might return a bogus error here.
There was a problem hiding this comment.
src/driver.rs
Outdated
| let c_name = CString::new(name)?; | ||
| let c_driver = unsafe { gdal_sys::GDALGetDriverByName(c_name.as_ptr()) }; | ||
| if c_driver.is_null() { | ||
| return Err(_last_null_pointer_err("GDALGetDriverByName")); |
There was a problem hiding this comment.
| /// | ||
| /// Wraps [`GDALRegisterDriver()`](https://gdal.org/api/raster_c_api.html#_CPPv418GDALRegisterDriver11GDALDriverH) | ||
| pub fn register_driver(driver: &Driver) -> usize { | ||
| let index = unsafe { gdal_sys::GDALRegisterDriver(driver.c_driver) }; |
There was a problem hiding this comment.
It's not impossible, but it's pretty hard to end up needing to call this (because we do _register_drivers in Get*). But we should have it, of course.
|
|
||
| /// Prevents the automatic registration of all known GDAL drivers when first calling create, open, etc. | ||
| pub fn prevent_auto_registration() { | ||
| START.call_once(|| {}); |
|
bors d+ |
|
✌️ ChristianBeilschmidt can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
|
Build succeeded: |
CHANGES.mdif knowledge of this change could be valuable to users.I added a wrapper for the
DriverManager.I moved some methods to this struct's impl and deprecated them in the
Driver.Moreover, I created integration tests that use the manager. They would interfere with other tests.