Call cargo directly instead of using actions-rs/cargo #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdroenner
reviewed
Oct 31, 2022
lnicola
force-pushed
the
rm-cargo-action
branch
2 times, most recently
from
91a227c to
50d79f0
Compare
lnicola
force-pushed
the
rm-cargo-action
branch
from
50d79f0 to
6cca2bf
Compare
jdroenner
approved these changes
Oct 31, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
325: Call cargo directly instead of using actions-rs/cargo r=jdroenner a=lnicola - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- `actions-rs` is unmaintained, and doesn't bring us that much. I think we might lose the nice GitHub integration, but it wasn't really working anyway. Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
|
bors r=jdroenner |
|
Already running a review |
|
bors retry |
|
Already running a review |
|
bors r- |
|
Canceled. |
|
bors r=jdroenner |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
325: Call cargo directly instead of using actions-rs/cargo r=jdroenner a=lnicola - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- `actions-rs` is unmaintained, and doesn't bring us that much. I think we might lose the nice GitHub integration, but it wasn't really working anyway. Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
|
Canceled. |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.actions-rsis unmaintained, and doesn't bring us that much. I think we might lose the nice GitHub integration, but it wasn't really working anyway.