Add build.rs to gdal-sys #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the last FFI call to gdal-sys. Silenced some warnings.
frewsxcv
reviewed
Feb 26, 2017
gdal-sys/build.rs
Outdated
| let link_type = "dylib"; | ||
| let lib_name = "gdal"; | ||
|
|
||
| #[cfg(target_family="windows")] |
There was a problem hiding this comment.
https://doc.rust-lang.org/reference.html#conditional-compilation
You should be able to make this just #[cfg(windows)]
frewsxcv
reviewed
Feb 26, 2017
gdal-sys/build.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[cfg(target_family="unix")] |
frewsxcv
approved these changes
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
build.rsto gdal-sys to enable building on windows. Building on windows requires$GDAL_HOMEto point to the base of the GDAL installation. The gnu toolchain works ifgdal_i.libis found in$GDAL_HOME\libor if agdal{version}.dllis found in$GDAL_HOME\bin. Msvc works only when the lib is available.Additionally i moved the last FFI call to gdal-sys and silenced some warnings..