Add SpatialRef::to_projjson() #389

ttencate · 2023-04-24T10:36:15Z

I agree to follow the project's code of conduct.
I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

lnicola · 2023-04-24T10:43:51Z

src/spatial_ref/srs.rs

+        } else {
+            Ok(_string(c_projjsonstr))
+        };
+        unsafe { gdal_sys::VSIFree(c_projjsonstr.cast::<std::ffi::c_void>()) };


I don't even know any more which one of .cast(), .cast<c_void>() or as _ is preferred 😃. At least this is consistent with the rest of the code.

Yeah, it's mostly a copy/paste... The entire lib could do with some helper functions/macros to streamline stuff like this.

lnicola · 2023-04-24T10:44:51Z

src/spatial_ref/srs.rs

@@ -506,6 +506,22 @@ impl SpatialRef {
        res
    }

+    pub fn to_projjson(&self) -> Result<String> {


I hate this spelling, TBH, but...

Me too, but it's consistent...

lnicola · 2023-04-24T10:58:22Z

bors r+

389: Add SpatialRef::to_projjson() r=lnicola a=ttencate - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- 390: Work around clippy lint bug r=lnicola a=lnicola - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Unblocks #389. Co-authored-by: Thomas ten Cate <ttencate@gmail.com> Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>

bors · 2023-04-24T11:00:44Z

Build failed (retrying...):

ci ubuntu-lts

389: Add SpatialRef::to_projjson() r=lnicola a=ttencate - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Co-authored-by: Thomas ten Cate <ttencate@gmail.com>

lnicola · 2023-04-24T11:01:52Z

bors r-

bors · 2023-04-24T11:01:54Z

Canceled.

390: Work around clippy lint bug r=lnicola a=lnicola - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Unblocks #389. Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>

lnicola · 2023-04-24T11:26:21Z

Looks like we're still testing GDAL 3.0.4 on CI, and OSRExportToPROJJSON was added in 3.1.

ttencate · 2023-04-24T12:43:44Z

Looks like we're still testing GDAL 3.0.4 on CI, and OSRExportToPROJJSON was added in 3.1.

Thanks. Added a check.

lnicola · 2023-04-24T12:45:11Z

Please drop that PAM file.

bors d+

bors · 2023-04-24T12:45:13Z

✌️ ttencate can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

ttencate · 2023-04-24T12:47:28Z

Please drop that PAM file.

Sorry, yeah, running cargo test keeps creating that for me (Arch Linux, GDAL 3.6.3). Should it be gitignored?

ttencate · 2023-04-24T12:48:01Z

bors r+

Thanks for the quick turnaround!

389: Add SpatialRef::to_projjson() r=ttencate a=ttencate - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Co-authored-by: Thomas ten Cate <ttencate@gmail.com>

lnicola · 2023-04-24T12:48:51Z

src/spatial_ref/srs.rs

+    #[cfg(any(major_ge_4, all(major_ge_3, minor_ge_1)))]
+    pub fn to_projjson(&self) -> Result<String> {
+        let mut c_projjsonstr = ptr::null_mut();
+        let options = ptr::null();


In the long run, I'd like us to support options where applicable:

https://gdal.org/doxygen/classOGRSpatialReference.html#a1a4b65b551d3a5ea91fb7fd8d9e1e4e8

lnicola · 2023-04-24T12:49:29Z

Sorry, yeah, running cargo test keeps creating that for me (Arch Linux, GDAL 3.6.3). Should it be gitignored?

I don't know, but I agree it's annoying :-).

bors · 2023-04-24T12:50:23Z

Canceled.

lnicola · 2023-04-24T13:05:56Z

tinymarble.tif.aux.xml strikes again!

ttencate · 2023-04-24T14:00:18Z

bors r+

389: Add SpatialRef::to_projjson() r=ttencate a=ttencate - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Co-authored-by: Thomas ten Cate <ttencate@gmail.com>

lnicola · 2023-04-24T14:02:34Z

bors r-

bors · 2023-04-24T14:02:36Z

Canceled.

lnicola · 2023-04-24T14:03:01Z

You've added the PAM file again when changing the assert message.

ttencate · 2023-04-24T18:29:59Z

Just added it to .gitignore so it won't bother anyone again.

ttencate · 2023-04-24T18:30:50Z

bors r+

bors · 2023-04-24T18:35:29Z

Build succeeded:

lnicola · 2023-04-25T06:30:35Z

Well, I was planning to fix TempFixture or the test to clean up better after itself 🙂.

ttencate · 2023-04-25T06:57:18Z

Well, I was planning to fix TempFixture or the test to clean up better after itself slightly_smiling_face.

That's great, but let's keep this thing from wasting everyone's time until you get round to it :)

ttencate force-pushed the feature/srs_to_projjson branch from b85800a to c39baff Compare April 24, 2023 10:36

lnicola reviewed Apr 24, 2023

View reviewed changes

lnicola approved these changes Apr 24, 2023

View reviewed changes

lnicola mentioned this pull request Apr 24, 2023

Work around clippy lint bug #390

Merged

2 tasks

ttencate force-pushed the feature/srs_to_projjson branch from c39baff to 4ed76c4 Compare April 24, 2023 12:43

ttencate force-pushed the feature/srs_to_projjson branch from 4ed76c4 to ba0f283 Compare April 24, 2023 12:46

lnicola reviewed Apr 24, 2023

View reviewed changes

ttencate force-pushed the feature/srs_to_projjson branch from ba0f283 to 308d288 Compare April 24, 2023 12:50

ttencate force-pushed the feature/srs_to_projjson branch from 308d288 to 5099745 Compare April 24, 2023 12:54

ttencate added 2 commits April 24, 2023 20:27

Add SpatialRef::to_projjson()

e482fbd

Ignore .aux.xml file generated by test runs

dcb09ae

ttencate force-pushed the feature/srs_to_projjson branch from 5099745 to dcb09ae Compare April 24, 2023 18:28

bors bot merged commit faf48e3 into georust:master Apr 24, 2023

metasim mentioned this pull request May 18, 2023

Release 0.15 #399

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SpatialRef::to_projjson() #389

Add SpatialRef::to_projjson() #389

ttencate commented Apr 24, 2023 •

edited

Loading

lnicola Apr 24, 2023

ttencate Apr 24, 2023

lnicola Apr 24, 2023

ttencate Apr 24, 2023

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

ttencate commented Apr 24, 2023

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

ttencate commented Apr 24, 2023 •

edited

Loading

ttencate commented Apr 24, 2023

lnicola Apr 24, 2023

lnicola commented Apr 24, 2023 •

edited

Loading

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

ttencate commented Apr 24, 2023

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

ttencate commented Apr 24, 2023

ttencate commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 25, 2023

ttencate commented Apr 25, 2023

Add SpatialRef::to_projjson() #389

Add SpatialRef::to_projjson() #389

Conversation

ttencate commented Apr 24, 2023 • edited Loading

lnicola Apr 24, 2023

Choose a reason for hiding this comment

ttencate Apr 24, 2023

Choose a reason for hiding this comment

lnicola Apr 24, 2023

Choose a reason for hiding this comment

ttencate Apr 24, 2023

Choose a reason for hiding this comment

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

ttencate commented Apr 24, 2023

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

ttencate commented Apr 24, 2023 • edited Loading

ttencate commented Apr 24, 2023

lnicola Apr 24, 2023

Choose a reason for hiding this comment

lnicola commented Apr 24, 2023 • edited Loading

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

ttencate commented Apr 24, 2023

lnicola commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 24, 2023

ttencate commented Apr 24, 2023

ttencate commented Apr 24, 2023

bors bot commented Apr 24, 2023

lnicola commented Apr 25, 2023

ttencate commented Apr 25, 2023

ttencate commented Apr 24, 2023 •

edited

Loading

ttencate commented Apr 24, 2023 •

edited

Loading

lnicola commented Apr 24, 2023 •

edited

Loading