Fix use-after-free in Dataset::close
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
force-pushed
the
fix-dataset-close
branch
from
0598227
to
8bea21e
Compare
lnicola
changed the title
Dataset::close
lnicola
force-pushed
the
fix-dataset-close
branch
from
8bea21e
to
6e87286
Compare
jdroenner
approved these changes
Jul 12, 2023
lnicola
force-pushed
the
fix-dataset-close
branch
from
6e87286
to
ef3c562
Compare
lnicola
force-pushed
the
fix-dataset-close
branch
from
ef3c562
to
59d7f6e
Compare
lnicola
commented
Jul 13, 2023
| @@ -174,6 +174,7 @@ impl GeoTransformEx for GeoTransform { | |||
| #[derive(Debug)] | |||
| pub struct Dataset { | |||
| c_dataset: GDALDatasetH, | |||
| closed: bool, | |||
There was a problem hiding this comment.
We could also have a wrapper around c_dataset and use ManuallyDrop on that instead.
There was a problem hiding this comment.
I switched to ManuallyDrop in 2e4b75e, but I'm not sure it's much better.
There was a problem hiding this comment.
Scratch that, it doesn't really work, because the inner type's drop still runs, and we can't get the return value of GDALClose out of there. I'll revert to the previous version.
lnicola
commented
Jul 13, 2023
lnicola
force-pushed
the
fix-dataset-close
branch
4 times, most recently
from
e181682
to
59d7f6e
Compare
|
r? @jdroenner |
|
sorry i forgot to merge this. Should we create a new release tomorrow? |
|
I might not be around tomorrow, but please do, if you can. I'd also yank the current version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.