Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable Feature geometry #42

Closed
jfirebaugh opened this issue May 9, 2016 · 2 comments
Closed

Nullable Feature geometry #42

jfirebaugh opened this issue May 9, 2016 · 2 comments

Comments

@jfirebaugh
Copy link

According to the GeoJSON specification, the "geometry" property of a Feature can be a JSON null value. I noticed that in other respects, nullability is reflected in the Rust API via Option, but this doesn't seem to be the case for the geometry field of geojson::Feature. Is this intentional?
@jfirebaugh jfirebaugh mentioned this issue May 9, 2016
Open
@frewsxcv
Copy link
Member

frewsxcv commented May 9, 2016

You are right, this was an oversight. I can make this change later today and release a new major version since this is a breaking change. Thanks for pointing this out!

frewsxcv added a commit that referenced this issue May 10, 2016
@frewsxcv
Permit geometry field on feature objects to be null.
1e11e85 
Fixes #42.
@frewsxcv frewsxcv mentioned this issue May 10, 2016
Merged
frewsxcv added a commit that referenced this issue May 10, 2016
@frewsxcv
Permit geometry field on feature objects to be null.
826861e 
Fixes #42.
frewsxcv added a commit that referenced this issue May 10, 2016
@frewsxcv
Permit geometry field on feature objects to be null.
c4b32cd 
Fixes #42.
frewsxcv added a commit that referenced this issue May 10, 2016
@frewsxcv
Permit geometry field on feature objects to be null.
22b7f08 
Fixes #42.
@frewsxcv
Copy link
Member

Version 0.3.0 has been published that includes the fix for this. Thanks again for filing this issue! 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfirebaugh @frewsxcv