Add conversions from Line, Triangle, Rect and GeometryCollection #136
Conversation
We aren't creating Line, Triangle or Rect types, after all.
urschrei
force-pushed
the
add_geo_types
branch
from
7211512 to
24ace6b
Compare
| @@ -46,6 +46,42 @@ where | |||
| } | |||
| } | |||
|
|
|||
| #[cfg_attr(docsrs, doc(cfg(feature = "geo-types")))] | |||
There was a problem hiding this comment.
Any idea what this line accomplishes?
It seems similar to this rust-lang/rust#43348 which produces output in the docs like this "Unix only" label:
Looks like it was originally added for quick_collection in 12c4f18 but I don't see any effect:
No need to change anything in this PR - I realize this was copied from the similar methods in this file, just curious if anyone has context to see if it's working as intended.
There was a problem hiding this comment.
I think it was my attempt at adding a marker to the docs to indicate that it's only available when the geo-types feature is activated, but that functionality has either changed slightly, or I screwed it up: https://stackoverflow.com/a/61417700/416626
| geo_types::Geometry::MultiLineString(ref multi_line_string) => { | ||
| geometry::Value::from(multi_line_string) | ||
| } | ||
| geo_types::Geometry::Polygon(ref polygon) => geometry::Value::from(polygon), | ||
| geo_types::Geometry::MultiPolygon(ref multi_polygon) => { | ||
| geometry::Value::from(multi_polygon) | ||
| } | ||
| _ => panic!("GeometryCollection not allowed"), |
|
Build succeeded: |
138: Fix feature labels for docs.rs r=urschrei a=urschrei Following up on #136 (comment) See here: https://stackoverflow.com/a/61417700/416626 Co-authored-by: Stephan Hügel <shugel@tcd.ie>
Closes #133