feature without 'properties' key doesn't error #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, good catch. |
urschrei
approved these changes
Apr 7, 2022
frewsxcv
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
https://datatracker.ietf.org/doc/html/rfc7946#section-3.2
Hmm it does seem to be required. I'm okay with this merging, though it could be nice to list out where we stray from the spec. Either in the top level crate docs, or on Feature. What do you think?
lnicola
approved these changes
Apr 8, 2022
Good call. I've added a doc to the Feature.properties. WDYT @frewsxcv I want to add something to the top level docs too, but I'd prefer to follow up (shortly!) with a light overhaul of the top level docs. Is that OK? |
Even though properties is required for features, sometimes in the wild it's missing. In the interest of being strict about what we emit while being permissive about what we accept, I think it'd be helpful for users to go forward when there is no properties key, and treat it just like null or empty properties.
michaelkirk
force-pushed
the
mkirk/handle-missing-props
branch
from
c97fd16
to
6819e37
Compare
|
squashed. bors r=urschrei I've got another docs PR coming momentarily if you'd like me to make any changes to the docs added here. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.I think "properties" is actually a required field for Feature and FeatureCollections, but sometimes in the wild it's missing.
In the interest of being strict about what we emit while being permissive about what we accept, I think it'd be helpful for users to go forward when there is no properties key, and treat it just like null or empty properties.
FWIW, ogr2ogr handles this without exploding.