Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #242

Merged
merged 4 commits into from
May 27, 2024
Merged

Fix deprecation warnings #242

merged 4 commits into from
May 27, 2024

Conversation

nk9
Copy link
Contributor

@nk9 nk9 commented May 26, 2024

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

When running the project from a fresh download, there are a number of compiler warnings which I have fixed.

Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify when these were introduced and that the corresponding non version of geo-types makes sense with this change?

@nk9
Copy link
Contributor Author

nk9 commented May 26, 2024

I'm not sure what you mean about the "non version" of geo-types? I could easily have my setup wrong, not looking to create work for you. If I've overlooked a contribution guide, or left steps out, please let me know!

@michaelkirk
Copy link
Member

michaelkirk commented May 26, 2024

sorry, "non" version was an autocorrect.

Can you please bump the min version of geo types in Cargo.toml to 0.7.13?

edit: fixed min version

@nk9
Copy link
Contributor Author

nk9 commented May 26, 2024

Sure, all done!

@michaelkirk michaelkirk added this pull request to the merge queue May 27, 2024
Merged via the queue into georust:main with commit 53f540a May 27, 2024
3 checks passed
@michaelkirk
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants