WIP: Use tiff ifd Value enum from tiff crate #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use tiff::decoder::ifd::Value (https://docs.rs/tiff/0.9.1/tiff/decoder/ifd/enum.Value.html) instead of the TagValue enum in src/lowlevel.rs. Note that SignedByte and SignedShort variants are currently commented out, wait for image-rs/image-tiff#234. Also fixed some clippy warnings.
weiji14
commented
Jul 22, 2024
Comment on lines
+136
to
+138
| // Type::SBYTE => Value::SignedByte(vec[0] as i8), // TODO wait for upstream SignedByte enum variant | ||
| Type::UNDEFINED => Value::Byte(0), | ||
| // Type::SSHORT => Value::SignedShort(Endian::read_i16(&vec[..])), // TODO wait for upstream SignedShort enum variant |
There was a problem hiding this comment.
TODO uncomment these lines once SignedByte and SignedShort variants are done in image-rs/image-tiff#234.
Suggested change
| // Type::SBYTE => Value::SignedByte(vec[0] as i8), // TODO wait for upstream SignedByte enum variant | |
| Type::UNDEFINED => Value::Byte(0), | |
| // Type::SSHORT => Value::SignedShort(Endian::read_i16(&vec[..])), // TODO wait for upstream SignedShort enum variant | |
| Type::SBYTE => Value::SignedByte(vec[0] as i8), | |
| Type::UNDEFINED => Value::Byte(0), | |
| Type::SSHORT => Value::SignedShort(Endian::read_i16(&vec[..])), |
weiji14
changed the title
weiji14
commented
Jul 22, 2024
Comment on lines
+146
to
+149
| Type::IFD => Value::Ifd(Endian::read_u32(&vec[..])), | ||
| Type::LONG8 => unimplemented!(), | ||
| Type::SLONG8 => unimplemented!(), | ||
| Type::IFD8 => unimplemented!(), | ||
| Type::IFD8 => Value::IfdBig(Endian::read_u64(&vec[..])), |
There was a problem hiding this comment.
Double check if read_u32 and read_u64 here is ok. Based on https://github.com/image-rs/image-tiff/blob/0c54a18e2130bd8e3e897009e1fb59eaaf607c6c/src/decoder/ifd.rs#L438-L442.
|
Big refactor at #17 means the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use
tiff::decoder::ifd::Valueinstead of the in-housecrate::lowlevel::TagValueenum.Part of #7.