Update for latest wkt #221
Conversation
| } | ||
|
|
||
| /// Process WKT geometry | ||
| fn process_wkt_geom<P: GeomProcessor>(geometry: &Geometry<f64>, processor: &mut P) -> Result<()> { | ||
| fn process_wkt_geom<P: GeomProcessor>(geometry: &wkt::Wkt<f64>, processor: &mut P) -> Result<()> { |
There was a problem hiding this comment.
can we simplify all these with use wkt::Wkt ?
There was a problem hiding this comment.
there are already other entities in the local module scope called Wkt. You could use an alias, but it's unlikely to be any more concise than wkt::Wkt.
|
When merged, will all the minor back and forth commits go into the main tree? |
|
I usually always squash commits when merging myself |
|
I switched the merge queue to use squash commits just now. For the record, as a staunch "rebase and merge-commit"-er, I find squashing barbaric, but barbarians have proven themselves very effective over the course of history. 😉 Another maintainer can LMK if they care. I'm open to undoing that change, but figured I'd rather be transparent about the change and ask for foregiveness than have a drawn out debate beforehand. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like new clippy is hitting new lint. I'll follow up with a fix. |
|
I wonder if clippy should be a non voting part of ci? Ie ok to merge, but show up as an error. -- your friendly barbarian |
I'm slightly in favor of that change, though don't feel strongly. Obviously this opens us up the risk of ignoring important clippy lints, but on balance, I'd support that change. It's disruptive that I frequently lose part of my day trying to move something along. Often it's just 5 minutes, but it's not uncommon for it to be 20 or more. It's especially annoying because IMO 80% of the time the clippy changes are neutral, 10% of the time they are dumb, and 10% of the time they are super helpful. To be clear, I'm pro-clippy. It's saved my bacon many times. I just don't like something with such a low signal to noise ratio scheduling my day for me. |
No description provided.