-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Update Rust versions in CI to 1.74, 1.78, and 1.79 #108
Conversation
…4.0 in CI workflow
Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
.github/workflows/test.yml
Outdated
on: push | ||
on: | ||
push: | ||
branches: [ "master" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to only run these on master
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to only run these on
master
?
No, I just thought it would be nice to let actions only run on importance branches like master. But maybe better to keep the original behavior 14c5816
CHANGELOG.md
Outdated
@@ -1,7 +1,7 @@ | |||
# CHANGELOG | |||
|
|||
## Unreleased | |||
|
|||
- [#108](https://github.com/georust/gpx/pull/108): Update MSRV to 1.74. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually bump rust-version
in the manifest, though I suspect it still builds on older versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually bump
rust-version
in the manifest, though I suspect it still builds on older versions?
I updated the changelog in f23ed65. This PR only changes the CI toolchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Yes we support older versions, but we don't know how to build them" doesn't make sense to me.
I'd say bump the rust-version, call it an MSRV and move on with your lives.
The alternative you're leading us down here is to have an MSRV that doesn't mean anything to anyone. How would we know when it breaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify: Whatever is listed as rust-version
in Cargo.toml should have a corresponding build in CI. If that means you need to bump rust-version, (I think) that's OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if we switch to rustup, we might not need to bump the MSRV.
Since we're at this, we should also update |
And do we really need a custom image, or can we build it directly? |
In the geo and proj repos anyway, we use libproj which takes a while to build, so having a custom image was the way that we cached that build to speed up CI. Probably you could set something else up though. Or if you're not using those dependencies, I expect you'd have luck using a standard container. |
Will do.
AFAIK the CI does not need a customzied container to do those actions:
|
Filed #109 as an alternative without the containers. |
CHANGELOG.md
if knowledge of this change could be valuable to users.This PR changes the rust toolchain for CI according to geo_types because geo_types no longer compiles with current CI settings.