Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty name tag in metadata #97

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

jasper-bosch
Copy link
Contributor

@jasper-bosch jasper-bosch commented Sep 28, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

I ran into an error while reading GPX files from Sports Tracker. Those files appear to contain an empty name tag (<name/>) in the metadata that results in a NoStringContent error:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<gpx xmlns="http://www.topografix.com/GPX/1/1" xmlns:gpxtpx="http://www.garmin.com/xmlschemas/TrackPointExtension/v1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" creator="Sports Tracker" version="1.1" xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd http://www.garmin.com/xmlschemas/TrackPointExtension/v1 http://www.garmin.com/xmlschemas/TrackPointExtensionv1.xsd">
<metadata>
    <name/>
    <desc/>
    <author><name>Jasper</name></author>
</metadata>
<trk>
    <name/>
    <trkseg>
    <trkpt...

There's also an empty name tag within the <trk>.

When I remove the <name/> from the file I can read it without any problems.

@lnicola
Copy link
Member

lnicola commented Oct 2, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 98da8cc into georust:master Oct 2, 2023
@jasper-bosch jasper-bosch deleted the allow-empty-name-tag-in-metadata branch October 3, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants