-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subsetted writes #5
Conversation
Travis is yelling at me, I need to fix that first :/ |
Hello again, It turns out that travis was yelling for 2 different reasons:
I will try to refactor the netcdf-sys crate in order to get it working with the future versions of rust (and the current beta and nightly version), but this problem is not related to this pull request, and all tests succeed on the stable channel, that's why I still wish to merge this PR, if you're OK with it. Thanks for your time. |
static". Use newly generated constants instead (from bindgen).
Hello again, I managed to refactor the netcdf-sys module to avoid the use of extern static bindings (which caused the build failure on the beta and nightly channels). The whole crate now compile without warnings, and all tests are successful using all rust versions :) Thanks for your time. |
This is great, thanks so much! |
Hello,
I've implemented subsetted writes using those functions from the libnetCDF library.
A user should now be able to:
I've also updated the documentation and the units tests accordingly,
I would love to see those changes merged, please tell me if anything is wrong with those.
Thanks for your time.