Updated workspace manifests to use relative paths to sibling packages #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
force-pushed
the
fix/relative-workspace
branch
from
9b2bc4b to
e7e3bbf
Compare
b4l
reviewed
Nov 6, 2022
There was a problem hiding this comment.
Relativ path are already set here as far as I understand it:
Line 12 in 4397542
They don't work for cases where you want to use a package outside of crates.io, e.g. as a local |
|
CI depends on #15 being fixed. |
for consistent referencing when imported as a source dependency. Also updated project repository link.
metasim
force-pushed
the
fix/relative-workspace
branch
from
e7e3bbf to
a34a812
Compare
|
@metasim so should we remove the |
I'll do that, but TBH, I've never published a multi-package crate, so we might need to roll it back... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures consistent inter-package cross referencing when imported as a source dependency.
Note: makes use of workspace features released in Rust 1.64.