Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for usage in tile-grid #18

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Changes for usage in tile-grid #18

merged 3 commits into from
Aug 6, 2023

Conversation

pka
Copy link
Member

@pka pka commented Jul 16, 2023

These are the changes I made for using ogcapi-types it in https://github.com/pka/tile-grid, but there is some cleanup needed, bevore it can be integrated.

@pka pka force-pushed the tile-grid branch 2 times, most recently from 7f59245 to 8dfa7b8 Compare July 16, 2023 21:48
@pka pka marked this pull request as ready for review July 16, 2023 22:26
Copy link
Member

@b4l b4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pka thank you for the pr! some files in the common module show up as empty which seems odd. apart from this, it's good to go.

@pka
Copy link
Member Author

pka commented Aug 4, 2023

Back from holidays and online again.

some files in the common module show up as empty which seems odd. apart from this, it's good to go.

I've removed the executable flag of these source files.

Will fix the clippy complaints though.

@pka
Copy link
Member Author

pka commented Aug 6, 2023

The remaining test failure looks like a setup problem:

test edr ... FAILED

failures:

---- edr stdout ----
Error: service error

Caused by:
    0: unhandled error
    1: unhandled error
    2: Error { code: "AccessDenied", message: "Access Denied.", request_id: "1778C5E05A035C33", s3_extended_request_id: "dd9025bab4ad464b049177c95eb6ebf374d3b3fd1af9251148b658df7ac2e3e8" }

@b4l
Copy link
Member

b4l commented Aug 6, 2023

@pka thanks for the clippy lints! fixed the test in 9f15439.

@b4l b4l merged commit 3f64fad into georust:main Aug 6, 2023
@pka pka deleted the tile-grid branch August 6, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants