Improve qc context definition and reporting #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a QcContext structure to manage Input Data (both parsed data as
Rinex
and file sources asPathBuf
).The current implementation makes it hard to report which file was provided by user, which is a nice teqc feature we should emulate.
The new
QcContext
defines the provided Data (files pool): and the idea is to build them once at the start of the application and avoid copying this structure.The QC report creation methods have also been improved. The previous API involved two calls:
QcReport::new
and thenQcReport::to_html()
. The problem with this dual process is the need to store the context in between, which we want to avoid for efficiency.This is now simplified to
QcReport::html()
to create the report, at once.The workspace has been moved to rinex-cli/workspace and is managed better thanks to the use of std::Path instead of simple strings. It is not possible to customize the workspace location at the moment, that will come later.
Improved the QC reporting:
HtmlReport
implementation, insideheader.rs
.