Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release build action #159

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Update release build action #159

merged 1 commit into from
Sep 7, 2023

Conversation

larsnaesbye
Copy link
Collaborator

Updates the (currently) unused build action as the first part of an attempt to revitalize them

@gwbres
Copy link
Collaborator

gwbres commented Sep 7, 2023

Hello @larsnaesbye

Thank you for your contribution, yep definitely need to put the release back to life.
Are you aware of any means to test the release portion, without an actual release ?

@larsnaesbye larsnaesbye merged commit dc089b3 into georust:main Sep 7, 2023
@larsnaesbye larsnaesbye deleted the update_build_action branch September 7, 2023 12:15
@larsnaesbye
Copy link
Collaborator Author

@gwbres - I was thinking of making test releases on my fork as they should not contaminate the official repository?

@larsnaesbye
Copy link
Collaborator Author

Hmm, it seems I cannot do that because one cannot create tags on forked repos. I will find another way....

@gwbres
Copy link
Collaborator

gwbres commented Sep 7, 2023

Well.. that's too bad because that would have been fairly easy...

@larsnaesbye
Copy link
Collaborator Author

Maybe I will just upload a copy to another repo and experiment from there.

@gwbres
Copy link
Collaborator

gwbres commented Sep 7, 2023

Maybe I will just upload a copy to another repo and experiment from there.

We'll have more release soon, i'm sure it will get fixed.
Do you have a little time to review my QC improvements ?

@gwbres
Copy link
Collaborator

gwbres commented Sep 9, 2023

  1. x86_64-unknown-linux-musl complains the linker flag -lz does not exist
  2. x86_64-apple-darwin did pass, but it complains it cannot create a directory that already exists.
    Looks like a faulty script or faulty docker environment
  3. x86_64-pc-windows-gnu did pass but it failed to publish to the server due to some credentials issues.
    Faulty docker environment, or faulty process once again. This error might have induced (2) ?
    image

@larsnaesbye
Copy link
Collaborator Author

larsnaesbye commented Sep 9, 2023

@gwbres I'm hoping for this: houseabsolute/actions-rust-cross#7 to be resolved and maybe use this action instead...

@gwbres
Copy link
Collaborator

gwbres commented Sep 9, 2023

It's already available, under his own name https://github.com/aaronvg/actions-rust-cross
We don't necessarily have to wait

@larsnaesbye
Copy link
Collaborator Author

Sure! I may be looking at it tomorrow :)

@larsnaesbye
Copy link
Collaborator Author

It got merged, so we can use the original repo now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants