only rinex-qc and cli need SP3 dependency #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Improve file production test environment by using temporary files that always get removed at the end of a given test. From time to time, we're facing some false negative test failures, due to the test execution being multi threaded, and basic file names like "tmp.rnx" or "test.crx" being used in separate test tasks. Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
larsnaesbye
approved these changes
Sep 8, 2023
lnicola
reviewed
Sep 8, 2023
| let copy_path = path.to_owned() + "-copy"; | ||
| assert_eq!(rnx.to_file(©_path).is_ok(), true); // test writer | ||
| let copy = Rinex::from_file(©_path); | ||
| let tmp_path = format!("test-{}.rnx", random_name(5)); |
There was a problem hiding this comment.
In gdal we use tempfile and something like https://github.com/georust/gdal/blob/c7f121c01748e92a271d960e7e48415c186a6c13/src/test_utils.rs#L11 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we split the QC into a separate library
With this simple random name generator, we make sure each tasklet creates a unique file.
We also made sure, in a previous contribution, that all temporary generated files get removed at the end of the test execution.