Fix incorrect RINEX v2 ionosphere parameter parsing #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #239 I made a mistake in parsing code for
IONO ...
header strings:String format is
2X,4D12.4
(https://files.igs.org/pub/data/format/rinex211.txt, table A3), which means there must 2 empty characters at the beginning of the line. In my code, I skip first 4 characters instead of 2, which can lead to errors inf64::from_str
further down the line. Unfortunately, existing tests were incorrect too, so mistake hasn't been caught early.I fixed parsing code and added more tests from credible sources.
Sorry for the bug.