-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing Z, M, and ZM WKT strings #115
Conversation
@michaelkirk since the changes from #110 might be fresh on your mind, do you want to look at the merge conflicts here and/or do you have suggestions for how to resolve them? Or do you want to look at the approach I took here and maybe rebase those onto the latest main? |
Some of the tests here come from the GEOS test suite in https://github.com/libgeos/geos/blob/8e525c825caf314d61a6279a426a59ded115681e/tests/unit/io/WKTReaderTest.cpp |
Sorry, I wouldn't have merged that if I knew you were working on this. I'll push up a resolution in a moment. The changes are pretty mechanical. |
I'm seeing some tests failing with your branch. Can you fix those up?
|
No worries! It was just bad luck! |
tests all pass locally now! |
Do you know why CI isn't running on this branch? |
I do not know why CI isn't running for your branch. Maybe related to the conflicts in the current branch? (working on those now) |
Ok - conflicts resolved. |
So we now only support |
That's correct. I don't ever use 3d points, but my understanding is that "POINT Z" is the correct spelling. Please let us know if you have compelling counter examples! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks @kylebarron!
I added support for |
Sure, since there is apparently some precedent for this spelling, I'm OK with (happy to?) support it. Thanks @kylebarron |
I had missed it but chapter 7 of https://www.ogc.org/standard/sfa/ does define WKT for geometries |
CHANGES.md
if knowledge of this change could be valuable to users.