Removed BPCH_DIAG compilation option #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeScripts/GC-ConfigureClassic.cmake - Removed the option BPCH_DIAG, which activated the binary punch diagnostics. This option is no longer needed. CHANGELOG.md - Updated accordingly Signed-off-by: ubuntu <ubuntu@aws.com>
yantosca
added
category: Feature Request
1 task
msulprizio
reviewed
Feb 27, 2024
There was a problem hiding this comment.
@yantosca It may be good to also remove the BPCH_DIAG option from the documentation in this pull request. Here are the occurrences I found:
source/geos-chem-shared-docs/supplemental-guides/customize-guide.rst:60: $ cmake .. -DTOMAS=y -DTOMAS_BINS=15 -DBPCH_DIAG=y
source/gcclassic-user-guide/compile-cmake.rst:112: * BPCH_DIAG: **ON** OFF
source/gcclassic-user-guide/compile-cmake.rst:279:.. option:: BPCH_DIAG
Thanks @msulprizio, I'll take care of it.
docs/source/gcclassic-user-guide/compile-cmake.rst - Removed references to the BPCH_DIAG compilation option, which has now been removed. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
msulprizio
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
These updates look good to merge alongside geoschem/geos-chem#2166. Note: They now also update submodule geos-chem-shared-docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This PR is the companion to geoschem/geos-chem#2166. It removes the
BPCH_DIAGCMake configuration option fromCMakeScripts/GC-ConfigureClassic.cmake.Expected changes
This is a zero-diff update. It does not contain any submodule hashes. It should be merged into dev/14.4.0 following geoschem/geos-chem#2166.
Related Github Issue(s)