Do not build KPP-Standalone executable unless specifically requested at compile time #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeScripts/GC-ConfigureClassic.cmake - Added boolean cache variable KPPSA and print its value src/CMakeLists.txt - Only execute the block where KPPSA_FILE_NAME is defined as a target if the KPPSA boolean variable is true. This will only build the KPP-Standalone executable when -DKPPSA=y is passed from the cmd line. src/GCHP_GridComp/GEOSChem_GridComp/CMakeLists.txt - Added boolean cache variable KPPSA CHANGELOG.md - Updated accordingly TODO: Update KPP-Standalone documentation accordingly in ReadTheDocs, which is located in the geos-chem-shared-docs submodule Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Feature Request
yantosca
changed the title
lizziel
approved these changes
Feb 6, 2025
|
All GCClassic integration tests (designated as gcc.3.f2fd5b) passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : 11e7d2e Fixed CMake gc_pretty_print statement for KPPSA variable
GEOS-Chem : e4b931b07 Ask user if they wish to build KPP-Standalone at rundir creation
HEMCO : 9cf873a Merge PR #304 (Add .zenodo.json; Update jinja2 to 3.1.5)
Cloud-J : f8a2b7f Update version number for 8.0.1 release
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 30
Submitted as SLURM job: 1379115
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also all tests were zero-diff w/r/t gcc.2.2b205b except for:
|
|
All GCHP integration tests (designated as gchp.3.c9cf46) passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : 1adb581 Now only build KPP-Standalone when -DKPPSA=y
MAPL : 6207fd0 Merge pull request #38 from geoschem/bugfix/intel_build_error_in_AbstractComponent
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem : e4b931b07 Ask user if they wish to build KPP-Standalone at rundir creation
HEMCO : 9cf873a Merge PR #304 (Add .zenodo.json; Update jinja2 to 3.1.5)
yaFyaml : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J : f8a2b7f Update version number for 8.0.1 release
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Number of execution tests: 12
Submitted as SLURM job: 1380789
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were zero-diff w/r/t the previous integration test gchp.2.dedfaf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR adds CMake updates so that the KPP-Standalone executable will not be built unless the user configures with the
-DKPPSA=yoption.Expected changes
This is a zero-diff update
Related Github Issue