-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG/ISSUE] HEMCO error with duplicate scale factors #143
Comments
Thanks for writing @ktravis213. We can make sure this is added into an upcoming HEMCO version (but realistically this might have to wait until after IGC10 in June, given other constraints). |
I just encountered this issue when validating CH4 in the carbon simulation with the latest development code (GEOS-Chem 14.2.0, HEMCO 3.7.0). My simulation completed without error even though I had several scale factors IDs that were defined twice in HEMCO_Config.rc:
I discovered only the second definition of the scale factor ID was used. In this case, that meant applying the incorrect scale factors to EDGARv7 CH4 emissions. We should prioritize adding a check in HEMCO to ensure that each scalID is defined only once to avoid issues like this in the future. |
…rbon The scale factors for applying seasonality to EDGARv7 CH4 emissions were previously defined with values 20-43. However, may of these values were used again for scale factors needed for CO and CO2 data. In that case, The EDGAR_SEASONAL scale factors were overwritten. To avoid this, the EDGAR_SEASONAL scale factors have been renumbered to 720-743. The same scale factors in the HEMCO_Config.rc.CH4/tagCH4 files remain unchanged because they do not include the scale factors for CO and CO2 and therefore do not have this conflict. NOTE: HEMCO does not crash when two scale factors are defined with the same ID. This has been reported in geoschem/HEMCO#143. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Request a new GEOS-Chem feature:
Hi support team! In HEMCO, the scale factors are all provided a number. You have to find an unused number to add your own scale factor for any purpose. I just ran into a problem where I moved code from an older HEMCO_Config.rc to a newer one in 13.4.0 and ended up with duplicate scale factors, but only after realizing my output looked odd. Could HEMCO throw an error message or crash if there are duplicate numbers used as scale factors?
The text was updated successfully, but these errors were encountered: