[PULL REQUEST] Bug fix in megan extension #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the AEF arrays were not reset to zero before the computation summing over plant types. Therefore the AEF values increased every timestep, which was a bug. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
These arrays are defined as single precision but the initialization value was previously hemco (flexible) precision. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
"Array_16" was previously allocated and initialized twice. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
changed the title
yantosca
approved these changes
Apr 8, 2022
|
This bug fix applies to GCHP and GEOS only since the computation of the annual scale factors occurs every timestep in those models. It is only called in the first timestep in GC-Classic. |
|
This bug fix is included in GEOS-Chem 14.0.0. |
yantosca
added
category: Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the HEMCO megan extension where the biogenic annual emissions factors (AEF) were not zeroed out between emission runs. The factors are computed by summing values in a loop over plant types. Unless the values are reset to zero before the loop there is cumulative summing across timesteps.
Also in this PR are a few minor changes to the megan extension:
(1) initialize arrays set from the restart file to single precision rather than double precision
(2) remove duplicate code to allocate module variable Array_16
(3) clean up a few comments
Testing the impact of these changes is in progress.