Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write HEMCO restart files to the rundir "Restarts/" subdirectory #202

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Mar 22, 2023

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This is the companion HEMCO PR to GEOS-Chem issue geoschem/geos-chem#1665 and PR geoschem/geos-chem#1718. HEMCO restart files (in non-ESMF modeling contexts) will now be written to the Restarts/ folder of the run directory.

We have also modified the run/createRunDir.sh script for the HEMCO standalone to create a Restarts folder in the HEMCO standalone run directory.

NOTE: This must be merged concurrently with geoschem/geos-chem#1718

Expected changes

None, this is a zero-diff update. We have verified that both GEOS-Chem Classic and the HEMCO standalone can read HEMCO restart files from the Restarts/ subdiretctory:

HEMCO: Opening ./Restarts/HEMCO_restart.201907020000.nc

Reference(s)

N/A

Related Github Issue(s)

Closes geoschem/geos-chem#1665

src/Core/hcoio_diagn_mod.F90
- Replace placeholder error messages with actual error messages
- Cosmetic changes

src/Core/hcoio_write_std_mod.F90
- In HCOIO_Write, we now write restart files (COL==2) to the
  rundir Restarts/ folder.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
run/createRunDir.sh
- Create a Restarts folder in the rundir, where HEMCO restart files
  will be stored.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added category: Feature Request New feature or request topic: Configuration Files Related to HEMCO configuration files no-diff-to-benchmark This update will have no impact on benchmark simulations labels Mar 22, 2023
@yantosca yantosca requested a review from msulprizio March 22, 2023 20:10
@yantosca yantosca self-assigned this Mar 22, 2023
@yantosca yantosca modified the milestones: 3.7.0, In progress Mar 22, 2023
@yantosca
Copy link
Contributor Author

GEOS-Chem integration tests with this feature activated in HEMCO passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #a44299c GEOS-Chem submodule update: Restore Iy sink reactions
GEOS-Chem #e1c06cbfc Updated CHANGELOG.md for reading HEMCO restarts from ./Restarts
HEMCO     #582ff96 Create "Restarts/" folder in HEMCO standalone rundirs

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 46661765
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....PASS
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 26
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca
Copy link
Contributor Author

GCHP execution tests passed (except tagO3, which is a known issue to be fixed later)

==============================================================================
GCHP: Execution Test Results

GCClassic #0b6d0e2 GEOS-Chem submodule update: Restore Iy sink reactions
GEOS-Chem #e1c06cbfc Updated CHANGELOG.md for reading HEMCO restarts from ./Restarts
HEMCO     #582ff96 Create "Restarts/" folder in HEMCO standalone rundirs

Number of execution tests: 5

Submitted as SLURM job: 46661912
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....FAIL
gchp_merra2_TransportTracers........................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 4
Execution tests failed: 1
Execution tests not yet completed: 0

@msulprizio msulprizio changed the base branch from main to dev/3.7.0 March 31, 2023 12:44
run/createRunDir.sh Outdated Show resolved Hide resolved
@msulprizio msulprizio removed this from the In progress milestone Mar 31, 2023
run/createRunDir.sh
- Now use mkdir -p ${rundir}/Restarts to make the Restarts folder
  in the HEMCO standalone rundir.  This is now consistent with
  the rundir script in GCClassic.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes now look good to merge.

@msulprizio msulprizio merged commit 13abf5e into dev/3.7.0 Apr 10, 2023
@msulprizio msulprizio deleted the feature/hemco-restart-folder branch April 10, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will have no impact on benchmark simulations topic: Configuration Files Related to HEMCO configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Store HEMCO Restart files both in the "Restarts/" subfolder of the run directory
2 participants