-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write HEMCO restart files to the rundir "Restarts/" subdirectory #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Core/hcoio_diagn_mod.F90 - Replace placeholder error messages with actual error messages - Cosmetic changes src/Core/hcoio_write_std_mod.F90 - In HCOIO_Write, we now write restart files (COL==2) to the rundir Restarts/ folder. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
run/createRunDir.sh - Create a Restarts folder in the rundir, where HEMCO restart files will be stored. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Feature Request
New feature or request
topic: Configuration Files
Related to HEMCO configuration files
no-diff-to-benchmark
This update will have no impact on benchmark simulations
labels
Mar 22, 2023
1 task
GEOS-Chem integration tests with this feature activated in HEMCO passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #a44299c GEOS-Chem submodule update: Restore Iy sink reactions
GEOS-Chem #e1c06cbfc Updated CHANGELOG.md for reading HEMCO restarts from ./Restarts
HEMCO #582ff96 Create "Restarts/" folder in HEMCO standalone rundirs
Using 24 OpenMP threads
Number of execution tests: 26
Submitted as SLURM job: 46661765
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....PASS
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 26
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
GCHP execution tests passed (except tagO3, which is a known issue to be fixed later) ==============================================================================
GCHP: Execution Test Results
GCClassic #0b6d0e2 GEOS-Chem submodule update: Restore Iy sink reactions
GEOS-Chem #e1c06cbfc Updated CHANGELOG.md for reading HEMCO restarts from ./Restarts
HEMCO #582ff96 Create "Restarts/" folder in HEMCO standalone rundirs
Number of execution tests: 5
Submitted as SLURM job: 46661912
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....FAIL
gchp_merra2_TransportTracers........................Execute Simulation....PASS
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 4
Execution tests failed: 1
Execution tests not yet completed: 0 |
msulprizio
requested changes
Mar 31, 2023
run/createRunDir.sh - Now use mkdir -p ${rundir}/Restarts to make the Restarts folder in the HEMCO standalone rundir. This is now consistent with the rundir script in GCClassic. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
msulprizio
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes now look good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Feature Request
New feature or request
no-diff-to-benchmark
This update will have no impact on benchmark simulations
topic: Configuration Files
Related to HEMCO configuration files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion HEMCO PR to GEOS-Chem issue geoschem/geos-chem#1665 and PR geoschem/geos-chem#1718. HEMCO restart files (in non-ESMF modeling contexts) will now be written to the
Restarts/
folder of the run directory.We have also modified the
run/createRunDir.sh
script for the HEMCO standalone to create aRestarts
folder in the HEMCO standalone run directory.NOTE: This must be merged concurrently with geoschem/geos-chem#1718
Expected changes
None, this is a zero-diff update. We have verified that both GEOS-Chem Classic and the HEMCO standalone can read HEMCO restart files from the
Restarts/
subdiretctory:HEMCO: Opening ./Restarts/HEMCO_restart.201907020000.nc
Reference(s)
N/A
Related Github Issue(s)
Closes geoschem/geos-chem#1665