Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hg0 Emission Factors in hcox_gfed_include_gfed4.H #215

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Update Hg0 Emission Factors in hcox_gfed_include_gfed4.H #215

merged 1 commit into from
Jul 6, 2023

Conversation

emroy00
Copy link
Contributor

@emroy00 emroy00 commented Jun 2, 2023

Name and Institution (Required)

Name: Eric Roy
Institution: MIT

Confirm you have reviewed the following documentation

Describe the update

This pull request is based on geoschem/geos-chem#1817. Existing literature (Holmes et al. 2010) suggests an Hg0:CO ratio of 100 nmol mol-1 (or 7.17e-7), however current EFs exhibit Hg0:CO ratios that vary by land use category. @arifein found that this change to occurred during a 2018 update of GFED4 emission factors:

geoschem/geos-chem@131cb5d#diff-fadca1025a23200fb81c647a278d4100d5afb14632b3b40c68e17f65e32321e4

Expected changes

Initial comparisons of the impact of this change on annual Hg0 biomass burning emissions suggest a minor effect, though ensuring EFs are consistent with existing literature is important for a strong basis. Largest changes occur in "DEFO" and "BORF" land types. This impact is shown in the plots below for 2015:

GCEFIssue_060123

Reference(s)

Update would return GFED4 EFs to configuration of Holmes et al. (2010) (https://doi.org/10.5194/acp-18-7863-2018) and highlight that the EFs are a scaling factor of CO.

Tagging collaborators @arifein and @jennyfisher

Related Github Issue(s)

closes geoschem/geos-chem#1817

@emroy00
Update Hg0 Emission Factors in hcox_gfed_include_gfed4.H
eed84ea 
Updating emission factors to values consistent with Holmes et al. (2010) and emphasizing the assumed Hg0:CO scaling factor
@yantosca yantosca added category: Bug Something isn't working topic: HEMCO Extensions Pertaining to HEMCO extensions labels Jun 2, 2023
@yantosca yantosca self-requested a review July 6, 2023 17:51
@yantosca yantosca self-assigned this Jul 6, 2023
yantosca
yantosca approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple update that changes the GFED scale factors for Hg into multipliers of the CO scale factors (instead of absolute values). Good to merge.

@yantosca yantosca added this to the 3.7.1 milestone Jul 6, 2023
@yantosca yantosca changed the base branch from main to dev/3.7.1 July 6, 2023 17:58
@yantosca
Copy link
Contributor

yantosca commented Jul 6, 2023

This PR has been merged on top of geoschem/geos-chem#1799 (which uses HEMCO 3.7.0). Integration tests are running.

@yantosca
Copy link
Contributor

yantosca commented Jul 6, 2023

All GEOS-Chem Classic integration tests passed (except for TOMAS, which is a known issue that will be fixed later):

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #dae6c49 GEOS-Chem submod update: PR #1799 (Explicitly define tagCH4 sims)
GEOS-Chem #05bbc3ff1 PR #1799 post-merge bug fix: Fix syntax error in hco_interface_mod.F90
HEMCO     #c796bf3 Merge PR #215 (Update Hg0 em. factors in hcox_gfed_include_gfed4.H)

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 61547404
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....FAIL
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....FAIL
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 24
Execution tests failed: 2
Execution tests not yet completed: 0

Also, all GEOS-Chem Classic integration tests (except for those which are noted in #1682) were identical to geoschem/geos-chem#1799

Checking gc_05x0625_NA_47L_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_05x0625_NA_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS15
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS40
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_aerosol
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_carbon
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CO2
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_aciduptake
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_APM
   -> 3 differences found in OutputDir
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.Metrics.20190701_0000z.nc4 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.Metrics.20190701_0000z.nc4 
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/HEMCO_diagnostics.201907010000.nc 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/HEMCO_diagnostics.201907010000.nc 
   -> 1 difference found in Restarts
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 

Checking gc_4x5_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA_SVPOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_marinePOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_RRTMG
   -> 1 difference found in OutputDir
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
   -> No differences in Restarts

Checking gc_4x5_merra2_Hg
   -> 2 differences found in OutputDir
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_Hg/OutputDir/GEOSChem.SpeciesConc.20190101_0000z.nc4 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_Hg/OutputDir/GEOSChem.SpeciesConc.20190101_0000z.nc4 
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_Hg/OutputDir/HEMCO_diagnostics.201901010000.nc 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_Hg/OutputDir/HEMCO_diagnostics.201901010000.nc 
   -> 1 difference found in Restarts
      * GCC_14.2.1_r3/rundirs/gc_4x5_merra2_Hg/Restarts/GEOSChem.Restart.20190101_0100z.nc4 
        GCC_14.2.1_r4/rundirs/gc_4x5_merra2_Hg/Restarts/GEOSChem.Restart.20190101_0100z.nc4 

Checking gc_4x5_merra2_metals
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_POPs_BaP
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCO
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

@yantosca
Copy link
Contributor

yantosca commented Jul 6, 2023

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCClassic #f4fe722 GEOS-Chem submod update: PR #1799 (Explicitly define tagCH4 sims)
GEOS-Chem #05bbc3ff1 PR #1799 post-merge bug fix: Fix syntax error in hco_interface_mod.F90
HEMCO     #c796bf3 Merge PR #215 (Update Hg0 em. factors in hcox_gfed_include_gfed4.H)

Number of execution tests: 5

Submitted as SLURM job: 61547770
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....PASS
gchp_merra2_TransportTracers........................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 5
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all GCHP integration tests were zero-diff w/r/t geoschem/geos-chem#1799.

Checking gchp_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_RRTMG
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

@yantosca yantosca merged commit c796bf3 into geoschem:dev/3.7.1 Jul 6, 2023
yantosca added a commit that referenced this pull request Jul 6, 2023
@yantosca
PR #215 post-merge fixes: Update CHANGELOG.md & version numbers
24cf7e0 
CMakeLists.txt
docs/source/conf.py
src/Core/hco_error_mod.F90
- Updated version numbers from 3.7.0 to 3.7.1

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This was referenced Jul 6, 2023
Closed
Merged
@yantosca yantosca added category: Bug Fix Fixes a bug that was previously reported and removed category: Bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yantosca yantosca yantosca approved these changes

Assignees

@yantosca yantosca

Labels
category: Bug Fix Fixes a bug that was previously reported topic: HEMCO Extensions Pertaining to HEMCO extensions
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.

Possible bug in GFED4 Hg0 Emission Factors
2 participants
@emroy00 @yantosca