Add fixes for TOMAS simulations in GCHP #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous pull request merge, species for the TOMAS15 simulation were added to run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem. However, this causes non-TOMAS simulations to crash because those species aren't defined. To avoid this, those lines are removed from HISTORY.rc. Instead, the setupConfigFiles.sh script has been updated to add those lines to HISTORY.rc for TOMAS simulations using sed. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
…4.3.0 Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
A spun-up sample restart file has been provided for TOMAS simulations in GCHP courtesy of Betty Croft. The GCHP/createRunDir.sh script has been updated so that GCHP TOMAS simulations point to the updated file in GEOSCHEM_RESTARTS/v2024-01. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
yantosca
added
topic: GCHP
yantosca
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Hi @msulprizio, thanks for this PR. Mostly looks good but I did note a couple of minor points.
|
@BettyCroft: I'm OK with this. |
|
Thank you @yantosca! |
Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
yantosca
approved these changes
Feb 5, 2024
|
This update passes all GCClassic and GCHP integration tests. I have also confirmed zero differences in fullchem benchmark simulations from these updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
This pull request supersedes #2116, which included fixes for running TOMAS in GCHP. This pull request also includes:
setupConfigFiles.sh)This should be merged alongside:
Expected changes
These updates produce zero differences with respect to the full-chemistry benchmark simulation. They now allow all GCHP integrations (including TOMAS15) to pass:
Related Github Issue(s)