Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add small extension to get the edit on github button working #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lheagy
Copy link
Member

@lheagy lheagy commented Nov 29, 2024

@santisoler: if you have a couple of minutes, I would appreciate your thoughts on this. I suspect there is a simpler way to do this. I copied what we were doing from the gpg to get it working.

Also, this is a "good enough" for now fix. Ideally we will move this content over to myst md in the near future, so there isn't a big motivation to invest a lot in cleaning up sphinx.

edit I will get the tests passing first! (hopefully with #576)

This was referenced Nov 29, 2024
@santisoler
Copy link
Member

I merged #577, so I think we can safely close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants