Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention need for config edit for root/masterpw login #7449

Merged

Conversation

kannes
Copy link
Contributor

@kannes kannes commented Mar 1, 2024

I tried to log in to a misconfigured GeoServer as root with the masterpw and was horrified when it did not work. Only via Google I found out that one needs to explicitely enable this special login: https://docs.geoserver.org/2.24.x/en/user/security/passwd.html#keystore-password

This PR simply adds another line to the masterpw.info file so that there is a better chance for discovery. :)

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

Copy link
Member

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user interface setting is Allow "root" user to login as Admin when editing the default Master Password Provider.

@jodygarnett jodygarnett added backport 2.24.x Instructs the bot to create a 2.24.x backport PR on merge backport 2.25.x Instructs the bot to create a 2.25.x backport PR on merge labels Mar 3, 2024
@jodygarnett jodygarnett merged commit 255616c into geoserver:main Mar 3, 2024
9 of 10 checks passed
@aaime
Copy link
Member

aaime commented Mar 4, 2024

This PR was merged with failing QA, now the main branch is tainted and all PRs will fail QA as well.
The code formatting check failed, the code was not built with maven (see the QA documentation, linked from the checklist, which was not even compiled).

@jodygarnett there is no need to merge every single outstanding PR when doing a release, especially not one that fails some of the github actions check.

I'll close the backport and manually fix main....

@aaime
Copy link
Member

aaime commented Mar 4, 2024

Btw, is there a Jira ticket for this? Or think change won't show up in release notes/announcements.

@kannes
Copy link
Contributor Author

kannes commented Mar 4, 2024

Btw, is there a Jira ticket for this? Or think change won't show up in release notes/announcements.

Nope, all I got from atlassian.net was a loop of Sign In -> Spinning Icon -> Sign In. I'm sorry but I cannot invest time with troubleshooting yet another account on yet another proprietary website. :\

@kannes kannes deleted the mention_config_edit_for_masterpw_login branch May 16, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.24.x Instructs the bot to create a 2.24.x backport PR on merge backport 2.25.x Instructs the bot to create a 2.25.x backport PR on merge Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants