Skip to content

Commit

Permalink
updated tests and example
Browse files Browse the repository at this point in the history
  • Loading branch information
offtherailz committed Aug 7, 2017
1 parent cad2db7 commit e673fce
Show file tree
Hide file tree
Showing 5 changed files with 45 additions and 3 deletions.
18 changes: 18 additions & 0 deletions web/client/actions/__tests__/featuregrid-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ const {
deleteGeometryFeature, DELETE_GEOMETRY_FEATURE,
clearChangeConfirmed, CLEAR_CHANGES_CONFIRMED,
deleteFeaturesConfirm, DELETE_SELECTED_FEATURES_CONFIRM,
openFeatureGrid, OPEN_FEATURE_GRID,
closeFeatureGrid, CLOSE_FEATURE_GRID,
closeFeatureGridConfirm, CLOSE_FEATURE_GRID_CONFIRM,
closeFeatureGridConfirmed, FEATURE_GRID_CLOSE_CONFIRMED
} = require('../featuregrid');

Expand Down Expand Up @@ -175,6 +178,21 @@ describe('Test correctness of featurgrid actions', () => {
expect(retval).toExist();
expect(retval.type).toBe(DELETE_SELECTED_FEATURES_CONFIRM);
});
it('Test openFeatureGrid', () => {
const retval = openFeatureGrid();
expect(retval).toExist();
expect(retval.type).toBe(OPEN_FEATURE_GRID);
});
it('Test closeFeatureGrid', () => {
const retval = closeFeatureGrid();
expect(retval).toExist();
expect(retval.type).toBe(CLOSE_FEATURE_GRID);
});
it('Test closeFeatureGridConfirm', () => {
const retval = closeFeatureGridConfirm();
expect(retval).toExist();
expect(retval.type).toBe(CLOSE_FEATURE_GRID_CONFIRM);
});
it('Test saveError', () => {
const retval = saveError();
expect(retval).toExist();
Expand Down
10 changes: 9 additions & 1 deletion web/client/actions/__tests__/layers-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ var {
REFRESH_LAYERS,
LAYERS_REFRESHED,
LAYERS_REFRESH_ERROR,
BROWSE_DATA,
changeLayerProperties,
toggleNode,
sortNode,
Expand All @@ -39,7 +40,8 @@ var {
updateSettings,
refreshLayers,
layersRefreshed,
layersRefreshError
layersRefreshError,
browseData
} = require('../layers');
var {getLayerCapabilities} = require('../layerCapabilities');

Expand Down Expand Up @@ -223,4 +225,10 @@ describe('Test correctness of the layers actions', () => {
}
});
});
it('browseData', () => {
const layer = {id: "TEST", name: "test", url: "test"};
const action = browseData(layer);
expect(action.type).toBe(BROWSE_DATA);
expect(action.layer).toBe(layer);
});
});
2 changes: 1 addition & 1 deletion web/client/examples/featuregrid/stores/store.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
const Rx = require('rxjs');
const {featureTypeSelectedEpic, wfsQueryEpic, viewportSelectedEpic} = require('../../../epics/wfsquery');
const {getLayerFromId} = require('../../../selectors/layers');
const {featureTypeSelected, layerSelectedForSearch, LAYER_SELECTED_FOR_SEARCH, CLOSE_FEATURE_GRID} = require('../../../actions/wfsquery');
const {layerSelectedForSearch, LAYER_SELECTED_FOR_SEARCH, CLOSE_FEATURE_GRID} = require('../../../actions/wfsquery');
const {browseData} = require('../../../actions/layers');
const {clearChanges, setPermission, toggleTool} = require('../../../actions/featuregrid');
const {hasChangesSelector, hasNewFeaturesSelector} = require('../../../selectors/featuregrid');
Expand Down
13 changes: 12 additions & 1 deletion web/client/reducers/__tests__/featuregrid-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const expect = require('expect');
const featuregrid = require('../featuregrid');
const {setFeatures, dockSizeFeatures, setLayer, toggleTool, customizeAttribute, selectFeatures, deselectFeatures, createNewFeatures,
featureSaving, toggleSelection, clearSelection, MODES, toggleEditMode, toggleViewMode, saveSuccess, clearChanges, saveError, startDrawingFeature,
deleteGeometryFeature, geometryChanged, setSelectionOptions, changePage, featureModified, setPermission, disableToolbar} = require('../../actions/featuregrid');
deleteGeometryFeature, geometryChanged, setSelectionOptions, changePage, featureModified, setPermission, disableToolbar, openFeatureGrid, closeFeatureGrid} = require('../../actions/featuregrid');
const {featureTypeLoaded} = require('../../actions/wfsquery');
const {changeDrawingStatus} = require('../../actions/draw');

Expand All @@ -64,6 +64,17 @@ describe('Test the featuregrid reducer', () => {
expect(state.select).toExist();
expect(state.features).toExist();
});
it('openFeatureGrid', () => {
let state = featuregrid(undefined, openFeatureGrid());
expect(state).toExist();
expect(state.open).toBe(true);
});
it('closeFeatureGrid', () => {
let state = featuregrid(undefined, closeFeatureGrid());
expect(state).toExist();
expect(state.open).toBe(false);
expect(state.mode).toBe(MODES.VIEW);
});

it('selectFeature', () => {
// TODO FIX this test or the reducer
Expand Down
5 changes: 5 additions & 0 deletions web/client/selectors/__tests__/query-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const {
resultsSelector,
paginationInfo,
featureLoadingSelector,
isDescribeLoaded,
describeSelector,
getFeatureById,
attributesSelector
Expand Down Expand Up @@ -322,6 +323,10 @@ describe('Test query selectors', () => {
const describe = describeSelector(initialState);
expect(describe.elementFormDefault).toBe("qualified");
});
it('test isDescribeLoaded', () => {
const isLoaded = isDescribeLoaded(initialState, "editing:polygons");
expect(isLoaded).toBe(true);
});
it('test getFeatureById selector', () => {
const ft = getFeatureById(initialState, "poligoni.7");
expect(ft).toExist();
Expand Down

0 comments on commit e673fce

Please sign in to comment.