Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burger menu not visible in DEV for context #8523

Closed
1 task done
tdipisa opened this issue Aug 30, 2022 · 5 comments
Closed
1 task done

Burger menu not visible in DEV for context #8523

tdipisa opened this issue Aug 30, 2022 · 5 comments

Comments

@tdipisa
Copy link
Member

tdipisa commented Aug 30, 2022

Description

Its seems that due to recent updates in DEV the burger menu is no longer visible in DEV if configured for a context

How to reproduce

  • Open this context in edit mode
  • In the plugin wizard add the burger menu
  • Save and then open the context again

Expected Result

The sidebar disappear and the burger menu is available and functional

Current Result

A sidebar covering the burger menu with only the measurement tool is present.

image.png

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

The tool works well in QA.

Related comment is #8530 (comment)

@alexander-fedorenko
Copy link
Contributor

alexander-fedorenko commented Aug 31, 2022

Not caused by module plugins, see description here #8463 (comment)
Requires a minor fix in sidebar menu visibility logic.

alexander-fedorenko added a commit to alexander-fedorenko/MapStore2 that referenced this issue Aug 31, 2022
Added extra check to make sure that sidebar menu is hidden whenever burger menu is rendered on the page, regardless of the length of items to render in sidebar.
@tdipisa
Copy link
Member Author

tdipisa commented Sep 2, 2022

Relevant comment from @allyoucanmap in #8530 to resume the work for this issue as part of the 2022.02.01 iteration.

@offtherailz
Copy link
Member

offtherailz commented Nov 4, 2022

@allyoucanmap need to set the alwaysRender flag in the plugin to make it work and make this issue testable?

@ElenaGallo ElenaGallo self-assigned this Nov 4, 2022
@allyoucanmap
Copy link
Contributor

@offtherailz this PR has already the Measure plugin updated with alwaysRender
https://github.com/geosolutions-it/MapStore2/pull/8754/files#diff-434d509b048e12e9e1c4c92944d208355b10faf3f2528ff363b5113199ffb6d7R203

@offtherailz
Copy link
Member

Sorry my fault. I filtered commits for the review and then I forgot to reset before doing my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants