Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the option to select the Search service to use when performing a search #9751

Closed
12 tasks done
dsuren1 opened this issue Nov 27, 2023 · 2 comments · Fixed by #9770 or #9832
Closed
12 tasks done

Implement the option to select the Search service to use when performing a search #9751

dsuren1 opened this issue Nov 27, 2023 · 2 comments · Fixed by #9770 or #9832

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Nov 27, 2023

Description

MapStore supports the option to configure multiple search services and assign them a priority to sort results. However, a search is always triggered against each and every configured service.

We want to implement the option for users to select the search to use to perform a search.
The hamburger menu should list the available services

A bonus feature would be the option to configure an icon for each service (by extending the search service configuration).

Mock design

screencast-localhost_8081-2023.11.24-10_48_33.webm

More details

Acceptance criteria

  • Allow configured services to be nested under Search by Location Name
  • On selecting Search by Location Name, text search by default applies to all services configured
    • Tooltip should say Search on all services below
  • Each search service is listed under Search by Location Name as shown below
    image
  • Show sub-menu when services configured is more than one
  • On selecting a single search service, the text search applies only to that service.
    • Should we include default services configured in the search plugin along with the service selected i.e Override default services is applicable for each service? @offtherailz
      Feeback
      • if the user checks "Override default services" only the ones configured from the UI will be listed. Otherwise the configured from the UI will be added to the default ones.
      • If only one service is present in the list, the sub-menu is redundant and so is not shown.
      • If more then one service is present, so we will show the sub menu.
    • A placeholder can be configured in the wizard (By default, can we use the name of the service? @offtherailz ) - Feeback - Service name|Service type
    • Is a tooltip required on each service? @offtherailz - Feeback - Make it configurable like placeholder
      - [x]Is the option to configure an icon for each service applicable for this issue? Is the icon to be an image only? Or we support only the glyph icons supported in MS? Feeback - Future enhancement, based on client's request

Other useful information

Ref: https://github.com/geosolutions-it/geonode-dubai/issues/7

@dsuren1 dsuren1 self-assigned this Nov 27, 2023
@tdipisa
Copy link
Member

tdipisa commented Nov 27, 2023

... Override default services is applicable for each service? @offtherailz

I would say yes. @offtherailz do you have a different idea?

A placeholder can be configured in the wizard (By default, can we use the name of the service? @offtherailz )

I would say yes. Makes sense

Is a tooltip required on each service? @offtherailz

I would say yes, to be configured in the wizard through a config property

Is the option to configure an icon for each service applicable for this issue? Is the icon to be an image only? Or we support only the glyph icons supported in MS? @offtherailz

That's optional but I would say the second

@offtherailz
Copy link
Member

...Override default services is applicable for each service

"Override default services" functionality is already in place. It allows to override the default service configured (typically nominatim, but if you configure something else in localConfig, it will be added) instead of adding to that list the ones configured on the map.
My mock, that is similar to the final implementation (see linked branch in the linked support ticket) showed all the current services active) takes already the correct list.
So:

  • if the user checks "Override default services" only the ones configured from the UI will be listed. Otherwise the configured from the UI will be added to the default ones.
  • If only one service is present in the list, the sub-menu is redundant and so is not shown.
  • If more then one service is present, so we will show the sub menu.

A placeholder can be configured in the wizard (By default, can we use the name of the service? @offtherailz )

Yes, ok to add the configurable placeholder in wizard.
By default "Search on "<Service Name|Service Type>", so it will show "Search on Nominatim" or "Search on US States", "Search on WFS" that looks to be good defaults.Notice that the placeholder is handled also by the nested services system, make sure to not break it.

Is a tooltip required on each service?
Is not "required" in sense of mandatory, but can be configured optionally (as well as the placeholder).

Is the option to configure an icon for each service applicable for this issue?

Because it can be problematic (allow selection of image/glyph) I'd avoid to introduce icon customization now. A future enhancement, based on client requests, can be added in the future quite easy, so we can clarify effective utility of this feature on real use cases asked by customers.

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 29, 2023
@dsuren1 dsuren1 linked a pull request Nov 29, 2023 that will close this issue
6 tasks
@ElenaGallo ElenaGallo assigned ElenaGallo and unassigned ElenaGallo Dec 6, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Dec 19, 2023
giohappy pushed a commit that referenced this issue Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment