Fix #10701 enabling failures for wms requests with exception, for ImageWMS sources #10702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption, for ImageWMS sources
offtherailz
requested changes
Dec 3, 2024
web/client/utils/VectorTileUtils.js
Outdated
| @@ -13,3 +13,7 @@ export const VECTOR_FORMATS = [ | |||
| ]; | |||
|
|
|||
| export const isVectorFormat = (format) => VECTOR_FORMATS.indexOf(format) !== -1; | |||
|
|
|||
| export const isValidResponse = (response) => { | |||
There was a problem hiding this comment.
This is not a utility of vector tiles, but of WMS, so move this file.
Btw, even if I previously though that XML forma was enough, looking better, the WMS protocol tells to specify the format in the parameter.
https://docs.geoserver.org/main/en/user/services/wms/reference.html#exceptions
So let's document it a little, including what to improv. Something like "OGC protocol returns status = 200 with Exception in body, this function checks if the exception....".
tdipisa
added
the
BackportNeeded
offtherailz
requested changes
Dec 4, 2024
offtherailz
reviewed
Dec 4, 2024
offtherailz
reviewed
Dec 4, 2024
offtherailz
approved these changes
Dec 4, 2024
|
@ElenaGallo testable in DEV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #10701 enabling failures for wms requests with exception, for ImageWMS sources
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10701
What is the new behavior?
now it correctly triggers layerLoadError
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information