Converting extension to use dynamic import by default (module plugin mode), updating upstream to the latest master branch #36
Conversation
|
Extension can be installed for test using following zip file: |
|
Thank you so much @alexander-fedorenko. Once merged and tested we will have to backport only this commit to the 2022.02.xx branch of this repo:
As part of that backport, the MS revision of that branch must be updated to the latest 2022.02.xx of MS. |
tdipisa
added
BackportNeeded
Priority: High
C169-Rennes-Métropole-2021-GeOrchestra3
and removed
backport-required
| import Extension from './extension/plugins/Extension'; | ||
| import { name } from '../config'; | ||
|
|
||
|
|
||
| export default { | ||
| [name]: createPlugin(name, Extension) | ||
| [name]: Extension |
There was a problem hiding this comment.
Now createPlugin is called directly in extension recall system in MapStore, isn't it?
I'd like to ask you, as a double check, if we can still use old extensions with the new MapStore, if the createPlugin has been moved.
Can you confirm we can install an old or a new extension in the new MapStore?
There was a problem hiding this comment.
good point @offtherailz. @alexander-fedorenko ?
There was a problem hiding this comment.
@tdipisa @offtherailz Yes, there is an explicit check for the way of extension export. Old extensions just go through initialization process as before, while new extensions exported as a module will hit this check here geosolutions-it/MapStore2@4005b4e#diff-8940694ab1df4f2163502cdeaf4956a59db143ea8ebf133ddf771ea23d4250cfR157
Just to confirm, here is the context on dev running cadastrapp (it won't load layers because of missing backend path, but anyway, plugins is registered, rendered etc.) and sample extension converted to be registered as module plugin.
https://dev-mapstore.geosolutionsgroup.com/mapstore/#/context/cadastrapp_and_sample
|
Thank you @offtherailz. @alexander-fedorenko please backport only this commint in 2022.02.xx of this repo raising a backport PR as described here. |
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Extension exported to be imported then as a static plugin.
What is the new behavior?
Extension exported as a module plugin,
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information