Add definition for unsupportedProperties #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsers should be able to communicate which style properties are unsupported. This increases transparency and usability of a parser, as users/developers would be able to see which properties are un-/supported. Automated hiding of unsupported properties in the GUI could be another benefit.
This PR defines a structure for this case. An optional static attribute
unsupportedPropertiescan be added to a Parser. This object imitates the general structure of a rule, where every unsupported property must contain the value'unsupported'. An object can either be unsupported as a whole (IconSymbolizer: 'unsupported') or one or more properties of an object can be unsupported (IconSymbolizer: { size: 'unsupported' }).