Fixed DataView 64 bit parsing #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@constantinius Could you give this a review? This follows up a small bug on #132 |
|
I'd love to have at least some tests for this. Do you think you can add one for each case? (signed/unsigned, little/big endian) |
|
@constantinius I updated both int64 algorithms. I think they both work now. I'm not sure what |
|
Very nice, thanks a bunch! I'll have a detailed look and will merge then.
|
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hadn't noticed this class since it is only used reading the firstIFDOffset which is always (in theory) 16 for BigTiff, but I ran into some mal-formatted data so I figure this should be fixed.
I think we could also maybe just removeOpen to suggestions.DataView64all together and refactor to useDataSlice?EDIT: I realized that this method is static and the class hasn't been instantiated yet. Still open to other fixes if you think of anything!