Add support for colormap with floating point keys #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
reviewed
Feb 17, 2020
moradology
added a commit
that referenced
this pull request
Feb 18, 2020
moradology
added a commit
that referenced
this pull request
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for
ColorMapwith non-integer keys by looking for an incorrectly parsed value. If incorrectly parsed, the non-integer key is reconstructed. This appears to be safe because this code path is only exercised when we're attempting to decode aColorMapand not more generally as HOCON is being parsedChecklist
Demo
The example configuration now includes a set of floating point keyed
ColorMapsTesting Instructions
Closes #187