test: add ws image resized test

.pre-commit-config.yaml

@@ -5,7 +5,7 @@ repos:
     rev: v5.0.0
     hooks:
       - id: check-added-large-files
-        args: ["--maxkb=500"]
+        args: ["--maxkb=750"]
       - id: check-ast
       - id: check-builtin-literals
       - id: check-case-conflict

gischat/models.py

@@ -57,7 +57,7 @@ class GischatMessageModel(BaseModel):
 class GischatTextMessage(GischatMessageModel):
     type: GischatMessageTypeEnum = GischatMessageTypeEnum.TEXT
     author: str = GISCHAT_NICKNAME_FIELD
-    avatar: Optional[str] = None
+    avatar: Optional[str] = Field(default=None)
     text: str = GISCHAT_TEXT_MESSAGE_FIELD
 
     def __str__(self) -> str:
@@ -67,7 +67,7 @@ def __str__(self) -> str:
 class GischatImageMessage(GischatMessageModel):
     type: GischatMessageTypeEnum = GischatMessageTypeEnum.IMAGE
     author: str = GISCHAT_NICKNAME_FIELD
-    avatar: Optional[str] = Field()
+    avatar: Optional[str] = Field(default=None)
     image_data: str = Field(description="String of the encoded image")
 
 

tests/__init__.py

@@ -3,3 +3,4 @@
 MIN_AUTHOR_LENGTH = str(3)
 MAX_AUTHOR_LENGTH = str(32)
 MAX_MESSAGE_LENGTH = str(255)
+MAX_IMAGE_SIZE = str(800)

tests/conftest.py

@@ -4,7 +4,13 @@
 import pytest
 from fastapi.testclient import TestClient
 
-from tests import MAX_MESSAGE_LENGTH, MIN_AUTHOR_LENGTH, TEST_ROOMS, TEST_RULES
+from tests import (
+    MAX_IMAGE_SIZE,
+    MAX_MESSAGE_LENGTH,
+    MIN_AUTHOR_LENGTH,
+    TEST_ROOMS,
+    TEST_RULES,
+)
 
 
 def get_test_rooms() -> list[str]:
@@ -17,6 +23,7 @@ def client() -> Generator[TestClient, None, None]:
     os.environ["RULES"] = TEST_RULES
     os.environ["MIN_AUTHOR_LENGTH"] = MIN_AUTHOR_LENGTH
     os.environ["MAX_MESSAGE_LENGTH"] = MAX_MESSAGE_LENGTH
+    os.environ["MAX_IMAGE_SIZE"] = MAX_IMAGE_SIZE
     from gischat.app import app
 
     yield TestClient(app)

tests/test_images.py

@@ -0,0 +1,46 @@
+import base64
+from io import BytesIO
+
+import pytest
+from PIL import Image
+from starlette.testclient import TestClient
+
+from gischat.models import GischatMessageTypeEnum
+from tests import MAX_IMAGE_SIZE
+from tests.conftest import get_test_rooms
+
+CAT_IMAGE_PATH = "tests/img/cat.jpg"
+
+
+@pytest.mark.parametrize("room", get_test_rooms())
+def test_send_image_resized(client: TestClient, room: str):
+    original_image = Image.open(CAT_IMAGE_PATH)
+    ow, oh = original_image.size
+    assert ow == 1200
+    assert oh == 800
+
+    with client.websocket_connect(f"/room/{room}/ws") as websocket:
+        assert websocket.receive_json() == {
+            "type": GischatMessageTypeEnum.NB_USERS.value,
+            "nb_users": 1,
+        }
+        with open(CAT_IMAGE_PATH, "rb") as file:
+            image_data = file.read()
+            websocket.send_json(
+                {
+                    "type": GischatMessageTypeEnum.IMAGE.value,
+                    "author": f"ws-tester-{room}",
+                    "avatar": "cat",
+                    "image_data": base64.b64encode(image_data).decode("utf-8"),
+                }
+            )
+            data = websocket.receive_json()
+            assert data["type"] == GischatMessageTypeEnum.IMAGE.value
+            assert data["author"] == f"ws-tester-{room}"
+            assert data["avatar"] == "cat"
+            assert "image_data" in data
+            assert data["image_data"]
+
+            image = Image.open(BytesIO(base64.b64decode(data["image_data"])))
+            w, h = image.size
+            assert max(w, h) == int(MAX_IMAGE_SIZE)