Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorisation : utilise le Network Requests Manager de QGIS à la place de requests #165

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

Guts
Copy link
Member

@Guts Guts commented Apr 29, 2024

Principal problème avec requests : c'est un package tiers donc il n'hérite pas des configurations réseau de QGIS (proxy, etc.)

Du coup, j'ai refacto le network manager pour qu'il soit plus générique.

@Guts Guts requested a review from gounux April 29, 2024 14:27
@github-actions github-actions bot added the enhancement New feature or request label Apr 29, 2024
Copy link
Contributor

@gounux gounux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool @Guts ça m'avait traversé l'esprit aussi, merci

qtribu/logic/json_feed.py Show resolved Hide resolved
qtribu/logic/json_feed.py Show resolved Hide resolved
@Guts Guts merged commit b0b44f9 into main Apr 29, 2024
6 checks passed
@Guts Guts deleted the improve/do-not-use-python-requests-for-network-ops branch April 29, 2024 14:46
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants