Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the code to work with zig 0.8 #1

Merged
merged 4 commits into from
Nov 29, 2021
Merged

update the code to work with zig 0.8 #1

merged 4 commits into from
Nov 29, 2021

Conversation

toffaletti
Copy link
Contributor

  • bring code up to zig 0.8
  • add GitHub workflow ci
  • update readme

toffaletti
toffaletti commented Nov 29, 2021
View reviewed changes
src/base32.zig
} else {
var i: usize = 0;
while (i < size) : (i += 1) {
const x = b[i] & 31;
dst[i] = self.buf[b[i] & 31];
}
n += i;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I got this right. This branch doesn't seem to be covered by any of the tests.
Screen Shot 2021-11-28 at 11 38 52 PM

gernest
gernest approved these changes Nov 29, 2021
View reviewed changes
Copy link
Owner

@gernest gernest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks fantastic.

@gernest gernest merged commit 77152a9 into gernest:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gernest gernest gernest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toffaletti @gernest