Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop error for signal effects #122

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

gernsdorfer
Copy link
Owner

@gernsdorfer gernsdorfer commented Nov 28, 2023

dispatch store actions should run in an asapScheduler (ngrx/platform#3932 (comment))

@gernsdorfer gernsdorfer added the bug Something isn't working label Nov 28, 2023
@gernsdorfer gernsdorfer force-pushed the fix-loop-error-for-signal-effects branch from b906620 to fa08685 Compare November 28, 2023 11:46
Copy link

cypress bot commented Nov 28, 2023

Passing run #85 ↗︎

0 39 0 0 Flakiness 0

Details:

fix dispatch store actions with signal effects
Project: ngrx-lite Commit: 8639f8c3e4
Status: Passed Duration: 02:28 💡
Started: Nov 28, 2023 12:22 PM Ended: Nov 28, 2023 12:24 PM

Review all test suite changes for PR #122 ↗︎

@gernsdorfer gernsdorfer force-pushed the fix-loop-error-for-signal-effects branch 2 times, most recently from a14b9e0 to 9923746 Compare November 28, 2023 12:15
@gernsdorfer gernsdorfer force-pushed the fix-loop-error-for-signal-effects branch from 9923746 to 8639f8c Compare November 28, 2023 12:20
@gernsdorfer gernsdorfer merged commit a9e6893 into master Nov 28, 2023
5 checks passed
@gernsdorfer gernsdorfer deleted the fix-loop-error-for-signal-effects branch December 11, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant