fix mid autumn & national day #413

[ruralscenery]

References (non-English):

• https://www.dgpa.gov.tw/information?uid=82&pid=11398 Section 2
• https://news.pts.org.tw/article/638479

Starting from 2024, the "anniversaries and holidays that should be taken off" will be adjusted to "the day before New Year's Eve" and "Children's Day and National Tomb Sweeping Day"

[maread99]

Hi @ruralscenery, thank you for this PR. Seems that it's failing the tests on a simple flake 8 linting issue:

./exchange_calendars/exchange_calendar_xtai.py:147:1: W293 blank line contains whitespace

The holiday changes seem to be significant. I've included comments in the review asking for:

• references for those holidays where extra Mondays and Fridays are no longer being observed post 2023.
• dates to be added to the test fixture 'non_holidays_sample' to test that for these holidays the extra days are not being evaluated as holidays post 2023.

Thanks!

[maread99]

Hi @ruralscenery, thanks for making the changes. Sorry for not having looked at this earlier - I will do before the end of the week.

At the moment the tests are failing on the following linting issues:

./exchange_calendars/exchange_calendar_xtai.py:152:20: W291 trailing whitespace
./exchange_calendars/exchange_calendar_xtai.py:160:1: W293 blank line contains whitespace
./exchange_calendars/exchange_calendar_xtai.py:170:20: W291 trailing whitespace
./exchange_calendars/exchange_calendar_xtai.py:187:12: W291 trailing whitespace

[maread99]

Hi @ruralscenery

There are a lot of changes to the holidays here. I'm unable to find an English reference to verify the changes. That's not a problem, but I would ask that you confirm a couple of changes that would result from this PR are indeed intended and correct rather than unintentional. I've noted them in the latest review comments (the no longer making up for 'dragon_boat_festival' and 'mid_autumn_festival' holidays that fall on the weekend).

[ruralscenery]

Appreciate your attention to detail regarding the Dragon Boat Festival and Mid-Autumn Festival falling on weekends.

I can confirm that the changes are made in accordance with "Anniversaries and holidays are implemented in accordance with the provisions of these regulations"

According to the provisions of the new system, in the next five years, except for 2026, there will be no adjustment to holidays and make-up work and classes. The rest of the years will be adjusted once, and they all happen to be on the day before New Year's Eve.

non_holidays_sample: 2024-09-16, 2024-10-11, 2030-09-13

[maread99]

Thank you for that confirmation @ruralscenery.

You'll see I've added a commit which revises some documentation and renames some functions. The only actual code it touches is the function that was weekend_makeup (renamed as nearest_weekday_from_2014) which I've simplified. The changes are intended to make it all a bit clearer and are more concerned with was there already than your PR. The commit also formats to black.

Either let me know that you're happy with what I've done or push any proposed changes. Then I'll merge it and cut a new release so that all this is reflected in the latest PyPI version.

Thanks again for the PR!

[ruralscenery]

Thank you for the effort of review, It's look good to me