Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XTKS: Add 2025 vernal and autumnal equinoxes #431

Conversation

w3stling
Copy link

Added Vernal Equinox and Autumnal Equinox for 2025.

Source:
https://www.jpx.co.jp/english/corporate/about-jpx/calendar/

Workflow to modify an existing Exchange Calendar

  • [ ✅ ] Modify calendar class as required.
  • [ ✅ ] Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • [ ✅ ] Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • [ ✅ ] Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

@w3stling w3stling changed the title Xtks add 2025 vernal and autumnal equinoxes XTKS add 2025 vernal and autumnal equinoxes Nov 19, 2024
@w3stling w3stling changed the title XTKS add 2025 vernal and autumnal equinoxes XTKS: Add 2025 vernal and autumnal equinoxes Nov 19, 2024
@gerrymanoim gerrymanoim merged commit 81f4e0a into gerrymanoim:master Nov 19, 2024
7 checks passed
@w3stling w3stling deleted the xtks-add-2025-vernal-and-autumnal-equinoxes branch November 20, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants