-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump max Python version to 3.13 #443
Conversation
Tests failing because numpy 1.26 won't build with python 3.13... The minimum version of pandas that we support is currently 1.5. So, seems that to support Python 3.13 we'll have to drop support for pandas v1 and numpy v1... (?) |
9f7d226
to
e23c076
Compare
.... all tests pass if we drop the 'pandas >= 1.5' restriction. @gerrymanoim, would you be happy to lose the minimum pandas 1.5 restraint in order that we can support Python 3.13? (Obviously users could still use Python 3.10 through 3.12 with pandas 1.5 and numpy 1.26). Cheers |
Could we change
to be
instead? That way we're still testing older pands/python but not blocking anyone on py13? I generally prefer to follow to the NEP support/drop schedule https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule, but I'm open to changing this if its painful. |
We could do, although if we're going to explicitly support 3.13 then should we lose the Shall I swap the requirements files over, as you suggest, and change the dependency in |
Yep - I think that makes sense to me - thanks! |
Updates test workflow to use `requirements_dev` instead of `requirements_minpandas`.
Bumps max Python version to 3.13.
Updates: