Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN issues July 2024 #447

Closed
chainsawriot opened this issue Jul 31, 2024 · 5 comments
Closed

CRAN issues July 2024 #447

chainsawriot opened this issue Jul 31, 2024 · 5 comments

Comments

@chainsawriot
Copy link
Collaborator

Dear maintainer,
Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_rio.html.
Please correct before 2024-08-18 to safely retain your package on CRAN.
Best,
-k

I think I can safely ignore the arrow one on r-devel-linux-x86_64-debian-clang because it's due to the installation issue of arrow.

But the second one is a mystery. I think I didn't see it yesterday. Is it transient?

@chainsawriot
Copy link
Collaborator Author

@chainsawriot
Copy link
Collaborator Author

Cannot reproduce the same problem on rhub2. Let's wait one day to see if that's transient CRAN problems.

@TimTaylor
Copy link

I can reproduce on current R-devel. Deleteing the following in .Rbuildignore will make it go away

^inst/doc/.+\.Rmd$

The CRAN commit that causes the issue is wch/r-source@a053afc.

Unsure whether this will change but may be worth tightening up the .Rbuildignore file anyway.

@chainsawriot
Copy link
Collaborator Author

@TimTaylor Thank you very much for the pointer! Super helpful information. I will amend as you suggested and perhaps test it with an offline Fedora with r-devel.

chainsawriot added a commit that referenced this issue Aug 1, 2024
@TimTaylor
Copy link

TimTaylor commented Aug 1, 2024

No worries. I wonder if this could catch out a few maturer packages that have accumulated bits in .Rbuildignore. Reading item 20 in https://cran.r-project.org/doc/manuals/R-exts.html#Checking-packages we have (emphasis mine):

... (If the vignette sources are in the deprecated location inst/doc, do mark such target output files to not be installed in .Rinstignore.)

So I guess historically (pre-dates my R usage), the vignette source was often kept there and hence rio's .Rbuildignore.

Hope this isn't teaching you to suck eggs so to speak. I just wanted to note it in this issue for my own reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants