Fix changes due to xml2 1.2.0 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming 1.2.0 release of xml2 fixes a bug in as_list.xml_document that cause the root node to be missing from the returned list. This fix unfortunately broke rio, which is fixed by the following changes.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming 1.2.0 release of xml2 fixes a bug in as_list.xml_document
that cause the root node to be missing from the returned list. This
fix unfortunately broke rio, which is fixed by the following changes.
Once xml2 1.2.0 has been release to CRAN (should be the next few days or weeks) you can remove the
Remotes:line and submit an updated rio version to CRAN.Sorry for the breakage and your understanding!