Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Add support for application config -> matchspecification -> entity? #84

Closed
karamelba opened this issue Jan 26, 2021 · 7 comments
Closed
Assignees
Labels
feature New feature or request

Comments

@karamelba
Copy link

Hi, i'd like to understand how to set the entity ('Destination' or 'Source') within the matchspecification of an application configuration.
The Instana APi https://instana.github.io/openapi/#operation/addApplicationConfig marks the field 'entity' as required.
If i create a match specification like 'kubernetes.namespace EQUALS 'xyz' via the terraform-provider-instana, the result is an application config with a match specification of type 'Destination'.
How can i achieve a match specification of type 'Source'?
Thanks a lot!

@gessnerfl gessnerfl self-assigned this Jan 26, 2021
@gessnerfl gessnerfl added the feature New feature or request label Jan 26, 2021
@gessnerfl
Copy link
Owner

@karamelba: this is currently not supported. I marked the ticket as a feature and will check how this can be supported

@karamelba
Copy link
Author

Great! Thank you :-)

@gessnerfl
Copy link
Owner

I will adjust the match expression syntax such as that you can optionally specify the entity origin (source or destination) after the entity path. For compatibility it will be defaulted to destination when the origin is omitted.

Examples:

entity.name      # no entity origin specified -> defaults to destination
entity.name@src  # entity name at the source of the call
entity.name@dest # entity name at the destination of the call

gessnerfl added a commit that referenced this issue Jan 28, 2021
@karamelba
Copy link
Author

Sounds great! :-)

gessnerfl added a commit that referenced this issue Jan 28, 2021
gessnerfl added a commit that referenced this issue Jan 28, 2021
gessnerfl added a commit that referenced this issue Jan 28, 2021
@gessnerfl
Copy link
Owner

Defaulting to destination is not a valid approach. There are entities which do not support source or destination. Will check if the API is defaulting the values properly. In the API entity is marked as required but this does not implemented like this.

gessnerfl added a commit that referenced this issue Jan 30, 2021
@gessnerfl gessnerfl changed the title Question: matchspecification - where is the entity? Add support for application config -> matchspecification -> entity? Feb 1, 2021
gessnerfl added a commit that referenced this issue Feb 1, 2021
…n_in_app_config_match_spec

#84 implementation completed. automated tests added. Q-metrics OK. Manual test executed including state migration.
@gessnerfl
Copy link
Owner

Feature is available with version 0.10.0

@karamelba
Copy link
Author

Thanks a lot for this enhancement!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants