Feature/77 sli configuration #81
Conversation
instana/resource-sli-config.go
Outdated
| SliConfigFieldMetricConfiguration: SliConfigMetricConfiguration, | ||
| SliConfigFieldSliEntity: SliConfigSliEntity, | ||
| }, | ||
| SchemaVersion: 1, |
There was a problem hiding this comment.
The initial schema version should be 0
There was a problem hiding this comment.
misconception on my part, initial schema version set to 0
instana/resource-sli-config.go
Outdated
| SliConfigFieldSliEntity: SliConfigSliEntity, | ||
| }, | ||
| SchemaVersion: 1, | ||
| StateUpgraders: []schema.StateUpgrader{ |
There was a problem hiding this comment.
For the initial version no state upgrader is required
There was a problem hiding this comment.
misconception on my part, state upgrader removed
instana/resource-sli-config.go
Outdated
| func mapStateToDataObjectForSliConfig(d *schema.ResourceData, formatter utils.ResourceNameFormatter) (restapi.InstanaDataObject, error) { | ||
| metricConfigurationsList := d.Get(SliConfigFieldMetricConfiguration).([]interface{}) | ||
| var metricConfiguration restapi.MetricConfiguration | ||
| if len(metricConfigurationsList) > 0 { |
There was a problem hiding this comment.
could be moved into a separate method mapMetricConfigurationEntityFromState()
There was a problem hiding this comment.
refactored into separate method
instana/resource-sli-config.go
Outdated
|
|
||
| sliEntitiesList := d.Get(SliConfigFieldSliEntity).([]interface{}) | ||
| var sliEntity restapi.SliEntity | ||
| if len(sliEntitiesList) > 0 { |
There was a problem hiding this comment.
could be moved into a separate method mapSliEntityListFromState()
There was a problem hiding this comment.
refactored into separate method
instana/resource-sli-config.go
Outdated
| ValidateFunc: func(val interface{}, key string) (warns []string, errs []error) { | ||
| v := val.(float64) | ||
| if v <= 0 { | ||
| errs = append(errs, fmt.Errorf("Metric threshold must be higher than 0")) |
There was a problem hiding this comment.
grammar: "must be greater than"
test case missing for the validation
instana/resource-sli-config.go
Outdated
| return d.Get(SliConfigFieldFullName).(string) | ||
| } | ||
|
|
||
| func sliConfigSchemaV0() *schema.Resource { |
There was a problem hiding this comment.
I think this is not needed anymore
| @@ -56,3 +57,7 @@ func (api *baseInstanaAPI) AlertingChannels() RestResource { | |||
| func (api *baseInstanaAPI) AlertingConfigurations() RestResource { | |||
| return NewRestResource(AlertsResourcePath, NewAlertingConfigurationUnmarshaller(), api.client) | |||
| } | |||
|
|
|||
| func (api *baseInstanaAPI) SliConfigs() RestResource { | |||
No description provided.